Add support for specifying container hostname #889
+37
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added withHostname * added getHostname
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@kyzooghost Pls add an example to the docs, in |
cristianrgreco
added
enhancement
cristianrgreco
changed the title
added with a cautionary note, please check :) |
cristianrgreco
approved these changes
Jan 20, 2025
|
@kyzooghost The build is failing. Probably the |
Will look into it when I can :) |
|
@cristianrgreco pushed another commit with AbstractStartedContainer.getHostname() method Ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #883
Added TestContainer.withHostname() and StartedTestContainer.getHostname()